[project-s] ハミング対応のエンジンでレンダリングできるようにする #1728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
reviewed
Jan 20, 2024
There was a problem hiding this comment.
エラーが起こる件に関して、とりあえず超ワークアラウンドですが解決策を見つけたので共有です！
こちらのINITIALIZE_ENGINE_SPEAKERを実行しないようにすれば一旦動きました！！
https://github.com/sigprogramming/voicevox/blob/e6a10c7ba0bb20c7a4b3b0f4fa9f1481fd897a4f/src/store/singing.ts#L207-L210
|
解決策ありがとうございます！ |
sigprogramming
requested review from
Hiroshiba,
romot-co and
a team
and removed request for
a team
sigprogramming
commented
Jan 20, 2024
| "singFrameAudioQuerySingFrameAudioQueryPost" | ||
| )({ | ||
| score: { notes }, | ||
| styleId: 999, // TODO: 設定できるようにする |
There was a problem hiding this comment.
styleIdはひとまず999固定にしています。
sigprogramming
commented
Jan 20, 2024
sigprogramming
commented
Jan 20, 2024
Hiroshiba
approved these changes
Jan 20, 2024
Comment on lines
+865
to
+869
| notes.push({ | ||
| key: undefined, | ||
| frameLength: restFrameLength, | ||
| lyric: "", | ||
| }); |
There was a problem hiding this comment.
（細かいですけど）この空っぽNoteをconst restNoteに入れるのもありだなと思いました！
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
ハミング対応のエンジンでレンダリングできるようにします。
また、以下も行います。
isSelfEventTarget関数が呼ばれていなかったので修正関連 Issue
VOICEVOX/voicevox_project#15
その他