[project-s] メニューを統一して切り替えUIをメニューに追加 #1748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
commented
Jan 23, 2024
Comment on lines
-539
to
-543
| // engineInfos、engineManifests、enableMultiEngineを見て動的に更新できるようにする | ||
| // FIXME: computedにする | ||
| watch([engineInfos, engineManifests, enableMultiEngine], updateEngines, { | ||
| immediate: true, | ||
| }); |
There was a problem hiding this comment.
マルチエンジンの時の要リファクタリングだった項目が今回牙を剥きました 😇
もしよかったらこの辺りちょっと見ていただけると････！！ @sevenc-nanashi
Hiroshiba
commented
Jan 23, 2024
y-chan
reviewed
Jan 24, 2024
| :deep(.q-btn[aria-pressed="true"]) { | ||
| span { | ||
| font-weight: 700; | ||
| color: colors.$display !important; |
There was a problem hiding this comment.
Suggested change
| color: colors.$display !important; | |
| color: colors.$toolbar-button-display !important; |
こちらの方が、ダークテーマにした際の視認性が向上しそうでした...!
There was a problem hiding this comment.
ダークモードのこと完全に忘れてました、ありがとうございます！！
（display-on-primary`が意図としてあってそうだったのdeこっちにしようと思います！）
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
/homeを/talkに変更関連 Issue
スクリーンショット・動画など
その他
これで一応mainブランチにマージしてもいいはず！！