#1755 ダークモード対応(初期調整) #1796
Merged
#1755 ダークモード対応(初期調整) #1796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
reviewed
Jan 30, 2024
public/themes/dark.json
Outdated
Comment on lines
17
to
22
| "sequencer-white-cell": "#393939", | ||
| "sequencer-black-cell": "#2D2D2D", | ||
| "sequencer-main-divider": "#121212", | ||
| "sequencer-sub-divider": "#333333", | ||
| "sequencer-white-key": "#EEEEEE", | ||
| "sequencer-black-key": "#555555" |
There was a problem hiding this comment.
あ、そういえばここに色と役割の対応表をなんとなく作ってたんでした！
もしよかったら書き足していただけると 🙏
https://github.com/VOICEVOX/voicevox/blob/27867b3784f02360246debc5d0c7ce0e502d3bb8/docs/%E8%89%B2%E3%81%AB%E3%81%A4%E3%81%84%E3%81%A6.md
added 2 commits
January 30, 2024 14:34
|
スナップグリッドと拍グリッドで色変える必要あり |
sigprogramming
approved these changes
Jan 30, 2024
| y2="100%" | ||
| stroke-width="1" | ||
| class="sequencer-grid-measure-line" | ||
| /> |
There was a problem hiding this comment.
ここを消したことで、sequencer-grid-measure-lineがほぼ1pxで表示されるようになっていますが、sequencer-ruler-measure-lineは2pxになっていて少しずれて見えるので、1pxか2pxに合わせたほうが良いかもと思いました！（細かいですが…）
（sequencer-ruler-measure-lineのx1、x2を+0.5すると1pxに合わせられます）
There was a problem hiding this comment.
@romot-co
後で調整・今調整・議論するなどありそうですがどうするのが良さそうでしょうか 👀
（リリースに含めるかどうしようかなと）
There was a problem hiding this comment.
@Hiroshiba
あとで調整できればと思います…！(のちほど行いたいですが、このIssue初期リリース対応なので＆実用上問題なさそうなため
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
関連 Issue
ref #1755
close #1755
スクリーンショット・動画など
その他
※ 昼頃また調整できればと思いますが、時間がなかった場合のためプルリク作成