Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dev版のアップロードが失敗する問題を修正 #1848

Merged
merged 3 commits into from
Feb 20, 2024
Merged

fix: dev版のアップロードが失敗する問題を修正 #1848

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02fbce2
fix: dev版のアップロードが失敗する問題を修正
sabonerune Feb 15, 2024
992d4af
fix: 不要な移動処理を削除
sabonerune Feb 15, 2024
62bba9c
fix: 不要な権限付与処理を削除
sabonerune Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 8 additions & 26 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ jobs:
compressed_artifact_name: voicevox-windows-nvidia
app_asar_dir: prepackage/resources
installer_artifact_name: windows-nvidia-nsis-web
nsis_web_artifact_name: "VOICEVOX-CUDA Web Setup ${version}.${ext}"
nsis_web_artifact_name: "VOICEVOX-CUDA.Web.Setup.${version}.${ext}"
os: windows-2019
# Windows CPU
- artifact_name: windows-cpu-prepackage
Expand All @@ -99,7 +99,7 @@ jobs:
compressed_artifact_name: voicevox-windows-cpu
app_asar_dir: prepackage/resources
installer_artifact_name: windows-cpu-nsis-web
nsis_web_artifact_name: "VOICEVOX-CPU Web Setup ${version}.${ext}"
nsis_web_artifact_name: "VOICEVOX-CPU.Web.Setup.${version}.${ext}"
os: windows-2019
# Windows DirectML
- artifact_name: windows-directml-prepackage
Expand All @@ -109,7 +109,7 @@ jobs:
compressed_artifact_name: voicevox-windows-directml
app_asar_dir: prepackage/resources
installer_artifact_name: windows-directml-nsis-web
nsis_web_artifact_name: "VOICEVOX Web Setup ${version}.${ext}"
nsis_web_artifact_name: "VOICEVOX.Web.Setup.${version}.${ext}"
os: windows-2019
# macOS CPU
- artifact_name: macos-cpu-prepackage
Expand All @@ -119,7 +119,7 @@ jobs:
compressed_artifact_name: voicevox-macos-cpu
app_asar_dir: prepackage/VOICEVOX.app/Contents/Resources
installer_artifact_name: macos-cpu-dmg
macos_artifact_name: "VOICEVOX ${version}.${ext}"
macos_artifact_name: "VOICEVOX.${version}.${ext}"
os: macos-11

runs-on: ${{ matrix.os }}
Expand Down Expand Up @@ -294,7 +294,6 @@ jobs:
- name: Recover file permissions for macOS build
if: startsWith(matrix.artifact_name, 'macos-') # macOS
run: |
chmod +x "prepackage/VOICEVOX.app/Contents/MacOS/${{ matrix.macos_executable_name }}"
chmod +x "prepackage/VOICEVOX.app/Contents/MacOS/vv-engine/run"
chmod +x "prepackage/VOICEVOX.app/Contents/Frameworks/VOICEVOX Helper (GPU).app/Contents/MacOS/VOICEVOX Helper (GPU)"
chmod +x "prepackage/VOICEVOX.app/Contents/Frameworks/VOICEVOX Helper (Plugin).app/Contents/MacOS/VOICEVOX Helper (Plugin)"
Expand Down Expand Up @@ -471,31 +470,14 @@ jobs:
dist_electron/*.dmg
target_commitish: ${{ github.sha }}

- name: Create Windows NSIS Web artifact directory
if: endsWith(matrix.installer_artifact_name, '-nsis-web')
run: |
mkdir -p nsis-web-artifact
mv dist_electron/nsis-web/out/*.7z.* nsis-web-artifact/
mv dist_electron/nsis-web/*.exe nsis-web-artifact/

# Rename file name like "VOICEVOX Web Setup X.X.X.exe" to "VOICEVOX.Web.Setup.X.X.X.exe".
- name: Rename Windows NSIS Web Installer
if: endsWith(matrix.installer_artifact_name, '-nsis-web')
run: |
cd nsis-web-artifact
OLD_NAME=`find . -maxdepth 1 -name '*.exe'`
# replace space by dot(.)
NEW_NAME=${OLD_NAME// /.}
mv "${OLD_NAME}" $NEW_NAME

- name: Upload Windows NSIS Web to Artifacts
if: endsWith(matrix.installer_artifact_name, '-nsis-web') && github.event.inputs.upload_artifact
uses: actions/upload-artifact@v3
with:
name: ${{ matrix.installer_artifact_name }}-release
path: |-
nsis-web-artifact/*.7z.*
nsis-web-artifact/*.exe
dist_electron/nsis-web/out/*.7z.*
dist_electron/nsis-web/*.exe

- name: Upload Windows NSIS Web to Release Assets
if: endsWith(matrix.installer_artifact_name, '-nsis-web') && (github.event.release.tag_name || github.event.inputs.version) != ''
Expand All @@ -504,6 +486,6 @@ jobs:
prerelease: ${{ github.event.inputs.prerelease }}
tag_name: ${{ env.VOICEVOX_EDITOR_VERSION }}
files: |-
nsis-web-artifact/*.7z.*
nsis-web-artifact/*.exe
dist_electron/nsis-web/out/*.7z.*
dist_electron/nsis-web/*.exe
target_commitish: ${{ github.sha }}
Loading