Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HelpDialog内のレイアウトをNavigationViewに置き換え・調整 #2262

Merged

Conversation

takusea
Copy link
Contributor

@takusea takusea commented Sep 7, 2024

内容

HelpDialog内のレイアウトをNavigationViewに置き換えます。また、NavigationViewとHelpDialogへの軽微なデザイン調整を含みます。

  • NavigationViewの一番外側の要素で新デザインの色の文字色を指定するように
  • 利用規約のsubtitleに上マージンを微量に付ける

スクリーンショット・動画など

image

@takusea takusea requested a review from a team as a code owner September 7, 2024 15:44
@takusea takusea requested review from Hiroshiba and removed request for a team September 7, 2024 15:44
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほぼLGTMです!!

以前のTODO箇所を改善できていていい感じ!!

src/components/Dialog/HelpDialog/HelpDialog.vue Outdated Show resolved Hide resolved
@@ -328,6 +312,6 @@ const openLogDirectory = () => window.backend.openLogDirectory();
}

.q-tab-panels {
background: none;
display: contents;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(ただのコメントです!)
へーーーーーこれでこのdiv?がなかったことになるんですね!!!
こんなのあるんですね、知らなかった。

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@Hiroshiba Hiroshiba merged commit 6bac9f9 into VOICEVOX:main Sep 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants