refactor: extractVvppをVvppManagerから切り出す #2490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
のタスクで連結したvvppからengineIdを取得したいのですが、ここ周りの関数がごちゃついていて手をつけづらかったので一旦リファクタリングを入れてみました。
まずはコードの中身になるべく手をつけずにコード移動だけ行っています。
すると差分が分かりやすいはず！
その他
この後TODOコメントの中身を変更しつつリファクタリングを入れるか、一旦engineIdを取得する関数を作ろうかなと思ってます。