Hotfix: C++版のLinux armhf向けコアを製品版でビルドできるようにする #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aoirint
changed the title
Hiroshiba
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
#132 の影響で、0.12.1より新しいバージョンでLinux armhf向けの製品版リリースがされておらず、以降にリリースされたキャラクターやスタイルをarmhf環境で利用できない状態にあったので、0.13.x向けのHotfixとしてPRを出します。
armhf向けのビルドの場合、リンカに
--long-pltオプションを追加することで、製品版0.12.3以降のように埋め込みファイルが多い場合でもビルドできるようにしました。以下のDocker BuildKit/QEMUを使ったarmhf (armv7l)エミュレーション環境で、デモモデル（
model/のonnxモデル）によってexampleのsimple_ttsで正常に音声が生成されることを確認しました（ただし埋め込みファイル全体が正常なことをテストしているわけではない）。cmake -S . -B build実行に失敗することのWorkaround入り関連 Issue
その他