Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ONNX版自動ビルド: Release用Artifactが入れ子のzipになっていたのを解消 #38

Merged
merged 2 commits into from
Nov 2, 2021

Conversation

aoirint
Copy link
Member

@aoirint aoirint commented Nov 2, 2021

内容

Artifactに自動ビルドの成果物をアップロードする際、
core.zipに圧縮してからアップロードしていたため、
Artifactのzipの中にcore.zipが入った、入れ子の状態になっていました。

このPRは、入れ子を解消し、core.zipを直接Artifact一覧からダウンロードできるようにします。

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 再度releaseを作成してみたいと思います。

@Hiroshiba Hiroshiba merged commit 42b4df8 into VOICEVOX:main Nov 2, 2021
@aoirint aoirint deleted the patch-artifact-unnest-zip branch October 17, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants