Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
example/python/run.pyの
logging
の設定に以下の変更を加えます。logging
のformat
において、%(filename)s
を%(name)s
にBefore
After
pyo3-logはRustの世界の
::
区切りのモジュール名をわざわざ.
区切りにしてまでPythonの世界の名前であるかのように扱っているため混乱が起きないかと思いはするのですが、%(filename)s
もlib.rsとかmod.rsとかだけになって情報量が無なので、%(name)s
の方がまだいいかなと思っています。対象モジュールを
__main__
(i.e. run.py),voicevox_core_python_api
(Rustのモジュール),voicevox_core
(Rustのモジュール) の3つに限定する新クラス設計API #370でasync_zipのログが出るようになってしまったので、それを抑える目的です。
関連 Issue
その他