CPU使用スレッド数を設定できるようにする #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
issue側に、環境変数よりinitialize関数の引数のが使いやすいかもという旨のコメントをしてみました。 |
AsPulse
reviewed
Jan 11, 2022
Hiroshiba
approved these changes
Jan 11, 2022
AsPulse
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
#63 の実装です
関連 Issue
ref #63
ref VOICEVOX/voicevox_engine#282
その他
VV_NUM_THREADSに不正な値が入ったときは例外をcatchせず落ちるようにしていますがこの方針でいいでしょうか？
またstd::getenvを使うとVC++だとwarningが出るのでいい方法があれば教えて下さい。よろしくおねがいします