Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: [Python] Sphinxをv8に上げ、extension達もアップデート #953

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Jan 28, 2025

内容

#952 を調査したときの副産物。必須ではないが、特に何の問題も無く上げられるということはわかったので今上げてしまう。

PyData Sphinx Themeを0.14 → 0.16に上げたからなのか、それともSphinxを6 → 8に上げたからなのか、ちょっと見た目が変わった。

image

関連 Issue

その他

@qryxip qryxip requested a review from Hiroshiba January 28, 2025 03:35
@qryxip qryxip changed the title docs: Sphinxをv8に上げ、extension達もアップデート docs: [Python] Sphinxをv8に上げ、extension達もアップデート Jan 28, 2025
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

sphinx-autoapiちょっと使われない気味になってきてるかも。

sphinx-autoapi https://pypistats.org/packages/sphinx-autoapi
sphinx https://pypistats.org/packages/sphinx

@qryxip
Copy link
Member Author

qryxip commented Jan 28, 2025

みたいですね。開発速度もまあ…うん…

@qryxip qryxip merged commit 23813b1 into VOICEVOX:main Jan 28, 2025
30 checks passed
@qryxip qryxip deleted the docs-bump-sphinx-to-8-and-so-on branch January 28, 2025 03:54
@Hiroshiba
Copy link
Member

知識がある今の段階が一番しんどくないはずなので、時間あればsphinx-autoapiの依存外しちゃっても良いかも・・・?
(できたhtmlのdiffを取ればどういう違いがあるかわかりそう)

まあでも0.16にとってのここの優先度は相当低いので、issue作るとかだけでも良いかも。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants