Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup clang-tidy #911

Merged
merged 37 commits into from
Apr 6, 2023
Merged

Setup clang-tidy #911

merged 37 commits into from
Apr 6, 2023

Conversation

jcoupey
Copy link
Collaborator

@jcoupey jcoupey commented Apr 3, 2023

Issue

Fixes #789

Tasks

@jcoupey
Copy link
Collaborator Author

jcoupey commented Apr 5, 2023

Trying to set this up carefully is a painful journey... But it did allow for some refactoring already and hopefully it will be useful in the long run.

Since the whole checking process is quite long, we don't really want to run it very often, not in CI anyway. I just added a simple makefile target to run the checks. It's probably not really portable since system include paths are hardcoded, but it will do for now.

There are a few remaining checks on which I have doubts, questions, or that would require much bigger overhaul. In order to keep this first setup simple but not loose the relevant info, I'll open a dedicated ticket to list concerns and ideas for improvements.

@jcoupey jcoupey merged commit 9b7165e into master Apr 6, 2023
@jcoupey jcoupey deleted the enhancement/use-clang-tidy branch April 7, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using clang-tidy
1 participant