add configuration to auto copy file remotely #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuwzho
reviewed
Jul 18, 2018
src/fileSyncer.ts
Outdated
| this._configuration = config; | ||
| } | ||
|
|
||
| protected hasConfigurationChanged(oldConfig: FileCopyConfigs, newConfig: FileCopyConfigs) { |
There was a problem hiding this comment.
This function name sounds like a function to detect whether there is change happens and the return type should be bool.
src/fileSyncer.ts
Outdated
| protected hasConfigurationChanged(oldConfig: FileCopyConfigs, newConfig: FileCopyConfigs) { | ||
| let result = []; | ||
|
|
||
| if (!oldConfig || oldConfig.length === 0) { |
There was a problem hiding this comment.
this conditional check can be written as oldConfig = oldConfig || []. This empty check should also be applied to newConfig. And then go to the original logic to merge two array
src/fileSyncer.ts
Outdated
| public async copyFiles(configuration: FileCopyConfigs, fileName: string = null) { | ||
| let servers = utilities.getSSHConfig(); | ||
|
|
||
| if (!configuration) { |
There was a problem hiding this comment.
configuration = configuration || this._configuration || []
src/fileSyncer.ts
Outdated
| return result; | ||
| } | ||
|
|
||
| public async copyFiles(configuration: FileCopyConfigs, fileName: string = null) { |
src/sshRunner.ts
Outdated
| // check configuration weather to sync workspace | ||
| let copyWorkspace = utilities.getCodeConfiguration<boolean>('ansible', 'copyWorkspace'); | ||
| if (fileSyncConfig) { | ||
| for (let config of fileSyncConfig) { |
There was a problem hiding this comment.
for (let config of (fileSyncConfig || [])) {
src/sshRunner.ts
Outdated
| } catch (err) { | ||
| return; | ||
| // if not saved on copy, copy playbook to remote | ||
| if (!config.copyOnSave) { |
There was a problem hiding this comment.
what if
- copyOnSave = false
- modified some file
- copyOnSave = true
- run
There was a problem hiding this comment.
run against old version.
|
|
||
| let childTokens = []; | ||
| child.split(/\\/).forEach((s) => childTokens = childTokens.concat(s.split(/\//).filter(i => i.length))); | ||
| return parentTokens.every((t, i) => childTokens[i] === t); |
There was a problem hiding this comment.
Need wait the forEach terminate?
yuwzho
approved these changes
Jul 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add new feature:
copy local saved files to remote ssh host.
Issue Type