Fixes #1763 and unfixes #612 (again)

package.json

@@ -122,7 +122,7 @@
       {
         "key": "tab",
         "command": "extension.vim_tab",
-        "when": "editorFocus && vim.active && !suggestWidgetVisible && !inDebugRepl"
+        "when": "editorFocus && vim.active && !inDebugRepl"
       },
       {
         "key": "ctrl+r",

src/actions/commands/insert.ts

@@ -182,19 +182,23 @@ class CommandInsertIndentInCurrentLine extends BaseCommand {
   }
 }
 
-@RegisterAction
-export class CommandInsertTabInInsertMode extends BaseCommand {
-  modes = [ModeName.Insert];
-  keys = ["<tab>"];
-  runsOnceForEveryCursor() { return false; }
-
-  public async exec(position: Position, vimState: VimState): Promise<VimState> {
-    vimState.recordedState.transformations.push({
-      type: "tab"
-    });
-    return vimState;
-  }
-}
+// Upon thinking about it some more, I'm not really sure how to fix this
+// elegantly. Tab is just used for so many things in the VSCode editor, and all
+// of them happen to be overloaded. Sometimes tab does a tab, sometimes it does
+// an emmet completion, sometimes a snippet completion, etc.
+// @RegisterAction
+// export class CommandInsertTabInInsertMode extends BaseCommand {
+//   modes = [ModeName.Insert];
+//   keys = ["<tab>"];
+//   runsOnceForEveryCursor() { return false; }
+
+//   public async exec(position: Position, vimState: VimState): Promise<VimState> {
+//     vimState.recordedState.transformations.push({
+//       type: "tab"
+//     });
+//     return vimState;
+//   }
+// }
 
 @RegisterAction
 export class CommandInsertInInsertMode extends BaseCommand {

src/mode/modeHandler.ts

@@ -1450,9 +1450,6 @@ export class ModeHandler implements vscode.Disposable {
           this._vimState.editor.selection = new vscode.Selection(newPos, newPos);
           break;
         case "tab":
-          // Temporary fix for #1763.
-          // TODO: Investigate into how to handle tab correctly
-          await vscode.commands.executeCommand('editor.emmet.action.expandAbbreviation');
           await vscode.commands.executeCommand('tab');
           if (command.diff) {
               if (command.cursorIndex === undefined) {

test/mode/normalModeTests/motions.test.ts

@@ -464,12 +464,13 @@ suite("Motions in Normal Mode", () => {
     end: ['!one', '!two', '|!three']
   });
 
-  newTest({
-    title: "Can handle dot with I with tab",
-    start: ['on|e', 'two', 'three'],
-    keysPressed: 'I<tab><Esc>j.j.',
-    end: ['  one', '  two', ' | three']
-  });
+  // This is still currently not possible.
+  // newTest({
+  //   title: "Can handle dot with I with tab",
+  //   start: ['on|e', 'two', 'three'],
+  //   keysPressed: 'I<tab><Esc>j.j.',
+  //   end: ['  one', '  two', ' | three']
+  // });
 
   newTest({
     title: "Can handle 0",