Fix case sensitive sorting (#4023)

Fixes #3939
VSCodeVim · Sep 1, 2019 · c246ac6 · c246ac6
1 parent afe8b1c
commit c246ac6
Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/src/cmd_line/commands/sort.ts b/src/cmd_line/commands/sort.ts
@@ -58,11 +58,9 @@ export class SortCommand extends node.CommandBase {
 
     let lastLineLength = originalLines[originalLines.length - 1].length;
 
-    const compareFn = this._arguments.ignoreCase
-      ? (a: string, b: string) => a.toLowerCase().localeCompare(b.toLowerCase())
-      : (a: string, b: string) => a.localeCompare(b);
-
-    let sortedLines = originalLines.sort(compareFn);
+    let sortedLines = this._arguments.ignoreCase
+      ? originalLines.sort((a: string, b: string) => a.localeCompare(b))
+      : originalLines.sort();
 
     if (this._arguments.reverse) {
       sortedLines.reverse();

diff --git a/test/cmd_line/sort.test.ts b/test/cmd_line/sort.test.ts
@@ -19,7 +19,7 @@ suite('Basic sort', () => {
   test('Sort whole file, asc', async () => {
     await modeHandler.handleMultipleKeyEvents([
       'i',
-      'b',
+      'B',
       '<Esc>',
       'o',
       'a',
@@ -30,7 +30,7 @@ suite('Basic sort', () => {
     ]);
     await commandLine.Run('sort', vimState);
 
-    assertEqualLines(['a', 'b', 'c']);
+    assertEqualLines(['B', 'a', 'c']);
   });
 
   test('Sort whole file, asc, ignoreCase', async () => {