Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

:tabe {file} is relative to current file #1162

Closed
gugahoa opened this issue Dec 15, 2016 · 1 comment · Fixed by #2400
Closed

:tabe {file} is relative to current file #1162

gugahoa opened this issue Dec 15, 2016 · 1 comment · Fixed by #2400
Labels
good first issue help wanted kind/bug size/S

Comments

@gugahoa
Copy link

gugahoa commented Dec 15, 2016

Please thumbs-up 👍 this issue if it personally affects you! You can do this by clicking on the emoji-face on the top right of this post. Issues with more thumbs-up will be prioritized.

What did you do?

In a folder with file1 in the workspace root and file2 inside {workspaceDir}/dir1 open file2 and press :tabe file1

What did you expect to happen?

file1 to be opened in another tab

What happened instead?

Plugin looked for file1 inside dir1 instead of {worspaceDir}

Technical details:

  • VSCode Version: 1.8.0
  • VsCodeVim Version: 0.4.9
  • OS: Arch Linux 64bits
@xconverge xconverge mentioned this issue Dec 16, 2016
Closed
@jpoon jpoon added the kind/bug label Apr 22, 2017
@jpoon
Copy link
Member

jpoon commented Apr 22, 2017

Yes, :tab should be operating at the "workshape" level which will correspond to vim implementatin.

@jpoon jpoon added the size/S label Apr 22, 2017
arussellk added a commit to arussellk/Vim that referenced this issue Feb 25, 2018
@arussellk
Fix :tabe {file} only relative to current file
9411168 
VSCodeVim#1162

:tabe {file} will now search through the first folder in your workspace (if
available) to try to open {file}.

If you are not in a workspace, :tabe {file} will search relative
to your current file.
@arussellk arussellk mentioned this issue Feb 25, 2018
Merged
jpoon added a commit to arussellk/Vim that referenced this issue Feb 26, 2018
@jpoon
Merge branch 'master' into fix/VSCodeVim#1162-tabe-relative-to-curren…
98416f6 
…t-file
jpoon pushed a commit that referenced this issue Feb 26, 2018
@arussellk @jpoon
Fix :tabe {file} only relative to current file (#1162) (#2400)
0b6dec0 
* Fix :tabe {file} only relative to current file

#1162

:tabe {file} will now search through the first folder in your workspace (if
available) to try to open {file}.

If you are not in a workspace, :tabe {file} will search relative
to your current file.

* Fix code formatting with `gulp forceprettier`

* await :tab* commands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted kind/bug size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix :tabe {file} only relative to current file (#1162) arussellk/Vim
2 participants
@jpoon @gugahoa