y}p handles newlines incorrectly

[Cody157]

Please thumbs-up 👍 this issue if it personally affects you! You can do this by clicking on the emoji-face on the top right of this post. Issues with more thumbs-up will be prioritized.

---

I'm going to give two variations that are handled incorrectly, but that I also expect might require separate logic.

Variation 1: Starting at the beginning of a line

What did you do?

|foo
fun

bar

where | marks the cursor position (and isn't actually a character),
press y}p

What did you expect to happen?

foo
|foo
fun
fun

bar

Notice that when cursor is at the beginning of the line, it treats it like a line copy and starts a new line when you paste. It also includes the newline after the second (final) line.

What happened instead?

f|foo
fun
oo
fun

bar

Here it starts pasting after the first character instead.

Variation 2: Starting in the middle of a line

What did you do?

f|oo
fun

bar

press y}p

What did you expect to happen?

fo|oo
funo
fun

bar

Notice that this does not copy the newline after the second (final) line.

What happened instead?

fo|oo
fun
o
fun

bar

Here it does copy the newline after the second (final) line.

I don't think I've ever personally used variation 2, but I checked how it was handled while comparing the first one, which I use fairly often.

Technical details:

• VSCode Version: 1.8.1
• VsCodeVim Version: 0.4.10
• OS: OS X El Capitan Version 10.11.6