Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double-click on word misses last character #1590

Closed
joa-quim opened this issue Apr 27, 2017 · 14 comments
Closed

Double-click on word misses last character #1590

joa-quim opened this issue Apr 27, 2017 · 14 comments

Comments

@joa-quim
Copy link

  • Click thumbs-up 👍 on this issue if you want it!
  • Click confused 😕 on this issue if not having it makes VSCodeVim unusable.

The VSCodeVim team prioritizes issues based on reaction count.


What did you do?

Double clicked one word

What did you expect to happen?

The full word to be selected

What happened instead?

last character in words was not selected

Technical details:

  • VSCode Version: 1.11.2
  • VsCodeVim Version: 0.6.16
  • OS: Win10
@Chillee
Copy link
Member

Chillee commented Apr 27, 2017

This should be fixed in the newest version, VSCodeVim version 0.6.20

PR #1542 should have fixed this issue.

@joa-quim
Copy link
Author

Hmm, for some reason VSC was not proposing updates. Restarting it showed them again. I have now 0.6.20 but the issue remains. Last character is still not picked.

@Chillee
Copy link
Member

Chillee commented Apr 27, 2017

Oh, when you say "last character was not selected", do you mean that it looks like the last character is not selected?

If you actually copy it, does it get the whole thing?

@joa-quim
Copy link
Author

It looks like it's not selected and ... ah I see the bug is actually in Ctrl+F. If you double-click to highlight and next do a Ctrl+F the last character is not copied into the search box.

@Chillee
Copy link
Member

Chillee commented Apr 28, 2017

Yeah the way we are currently handling selections is not ideal. There's an off by one error between what's actually selected (according to vscode), and we have selected (for the purposes of visual mode, etc.)

@dreel
Copy link

dreel commented Apr 28, 2017

The reproduction case that gets me is:

  1. double click on a word to select it
  2. hit cmd-c to copy it
  3. hit cmd-v to paste it

It should replace the word with itself since it is still selected, but instead it replaces all but the last letter. This also happens if you then double click on another word to try and replace it with the text in your copy buffer. This does not happen if you have the plugin disabled. I'm running 0.6.20.

@Chillee
Copy link
Member

Chillee commented Apr 28, 2017

@dreel I think rebornix is working on the problem. Somebody else brought up the exact problem you brought up in #1455 actually.

@dreel
Copy link

dreel commented Apr 28, 2017

Awesome, thanks!

@qws1986
Copy link

qws1986 commented May 10, 2017

it's still not fixed in v0.7.1.

@Chillee
Copy link
Member

Chillee commented May 10, 2017

@qws1986 He's not talking about with copy paste. He's talking about how it generally "looks" like it's not selected, and also that ctrl+f doesn't get the whole word.

@qws1986
Copy link

qws1986 commented May 10, 2017

@Chillee my mistake, it's not fixed. 😩

@hanchao886
Copy link

ye,it's not fixed in v0.7.1

@alexgorbatchev
Copy link

v0.8.4

vscodevim

@Chillee
Copy link
Member

Chillee commented Jun 24, 2017

Closed through #1862

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants