-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Double-click on word misses last character #1590
Comments
This should be fixed in the newest version, VSCodeVim version 0.6.20 PR #1542 should have fixed this issue. |
Hmm, for some reason VSC was not proposing updates. Restarting it showed them again. I have now 0.6.20 but the issue remains. Last character is still not picked. |
Oh, when you say "last character was not selected", do you mean that it looks like the last character is not selected? If you actually copy it, does it get the whole thing? |
It looks like it's not selected and ... ah I see the bug is actually in Ctrl+F. If you double-click to highlight and next do a Ctrl+F the last character is not copied into the search box. |
Yeah the way we are currently handling selections is not ideal. There's an off by one error between what's actually selected (according to vscode), and we have selected (for the purposes of visual mode, etc.) |
The reproduction case that gets me is:
It should replace the word with itself since it is still selected, but instead it replaces all but the last letter. This also happens if you then double click on another word to try and replace it with the text in your copy buffer. This does not happen if you have the plugin disabled. I'm running 0.6.20. |
Awesome, thanks! |
it's still not fixed in v0.7.1. |
@qws1986 He's not talking about with copy paste. He's talking about how it generally "looks" like it's not selected, and also that ctrl+f doesn't get the whole word. |
@Chillee my mistake, it's not fixed. 😩 |
ye,it's not fixed in v0.7.1 |
Closed through #1862 |
The VSCodeVim team prioritizes issues based on reaction count.
What did you do?
Double clicked one word
What did you expect to happen?
The full word to be selected
What happened instead?
last character in words was not selected
Technical details:
The text was updated successfully, but these errors were encountered: