Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix off by one error in visual mode #1862

Merged
merged 19 commits into from
Jun 24, 2017
Merged

Conversation

Chillee
Copy link
Member

@Chillee Chillee commented Jun 22, 2017

Fixes #1755, fixes #1719, #1590, #1455, #1160

List of fundamental breaking changes:

  1. Decoration instead of cursor.
  2. A block cursor doesn't show when we do visual mode on an empty line.
  3. When you do <d-d> and you don't have editor.selectionHighlight set to false, the carets don't appear.

It's done!

Also note that in anticipation of possible future delegation to Neovim, I have decided not to take this opportunitity to also refactor the yank/put logic.

@Chillee Chillee force-pushed the offbyonefix branch 3 times, most recently from 9a00ff4 to 75cbb41 Compare June 24, 2017 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incomplete selection/copy Missing last character when transfering word from doc to native search bar.
1 participant