-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tag matching self closing tag issue #1668
Labels
Comments
Neovim doesn't appear to handle self closing tags on my computer. |
I edit the comment. <div>
<div a=1/>
{{cursor here}}
</div> my vim8 handle it. And the code seems to want to handle it too. the regexp match CLOSE_FORWARD_SLASH |
I see. So we should be ignoring self closing tags. I think your solution looks pretty good to me, I'll try it. |
xconverge
added a commit
that referenced
this issue
May 17, 2017
Fixes #1668: Self closing tags not properly handled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The VSCodeVim team prioritizes issues based on reaction count.
Is this a BUG REPORT or FEATURE REQUEST? (choose one):BUG REPORT
Environment:
What happened:
can not match match self closing tag.
What did you expect to happen:
How to reproduce it:
In editor text like:
and then use cit command.
Maybe solution:
in tagMatcher.ts
TAG_REGEX may always not match TAG_REGEX CLOSE_FORWARD_SLASH
change to:
static TAG_REGEX = /<(/)?([^\>\<\s]+)[^\>\<]*?(/?)>/g;
and in
if (match[TagMatcher.CLOSE_FORWARD_SLASH]) {
match = TagMatcher.TAG_REGEX.exec(corpus); //<- add this line maybe
continue;
}
The text was updated successfully, but these errors were encountered: