-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual block mode doesn't navigate with gj/gk #1772
Comments
This seems to work for me, also I've re-mapped "vim.otherModesKeyBindings": [
{
"before": ["j"],
"after": ["g", "j"]
},
{
"before": ["k"],
"after": ["g", "k"]
}
] |
@nivv - Are you sure you're testing this with visual block mode, and not either plain visual or visual line modes? Both of those work for me, but visual block doesn't. I had the same keybindings, which is how I found the problem, and had to disable them to use visual block mode at all. It's worth noting this used to work just fine, I don't know exactly what version it was where the problem started though. This also on a different computer with some version updates,
|
Yeah this is a consequence of some changes we made to visual block mode to fix some other bugs (I think). I don't think it should be too hard to fix. |
Has there been any progress on this? I'm making the switch from vim to VS Code and I love it so far, but this fix would be really nice to have. I'd be willing to work on it myself if it really is fairly easy and if anyone can provide some starting guidance, because I have minimal experience with applications of this sort and zero experience with TypeScript. |
* Fix gj and gk in visual block mode Addresses #1772 * Add test for gj and gj in visual block mode * Resolve merge conflict * Add missing RegisterAction decorator * Change line endings to CRLF
The VSCodeVim team prioritizes issues based on reaction count.
Is this a BUG REPORT or FEATURE REQUEST? (choose one): Bug Report
Environment:
What happened:
Trying to navigate visual block mode with
gj
andgk
resulted in no vertical movement or selection.<ctrl-v>gj
What did you expect to happen:
The selection should now include the same block in the following line.
This happens regardless of whether it's navigating between multiple distinct lines, or a single, long word-wrapped line.
The text was updated successfully, but these errors were encountered: