Closing idle processes #2558
Comments
|
Weird, I thought we fixed this #2038. You should have as many Edit: So the |
|
I see the same (mac, stable vscode). I'm not using tabs so all files that are opened in background are enabling nvim process. Even if I close file the process is staying. |
VSC only automatically disposes resources when an extension is shutdown. Since every time a new TextEditor is opened, we also instantiate a new ModeHandler (along other Disposables like neovim processes), those pile up and will not get properly disposed until we get shutdown one way or the other. One issue this is causing is that neovim processes are not being cleaned up and hang around until our shutdown. Thus, every time we remove a ModeHandler, we manually dispose it to free its resources. Fixes VSCodeVim#2558.
VSC only automatically disposes resources when an extension is shutdown. Since every time a new TextEditor is opened, we also instantiate a new ModeHandler (along other Disposables like neovim processes), those pile up and will not get properly disposed until we get shutdown one way or the other. One issue this is causing is that neovim processes are not being cleaned up and hang around until our shutdown. Thus, every time we remove a ModeHandler, we manually dispose it to free its resources. Fixes VSCodeVim#2558.
|
VSC only disposes resources when an extension is shutdown, thus in this example, the I have opened a pull requested with a possible fix. (And sorry for the noise with the unintended older and wrong commit above. Sigh.) |
VSC only automatically disposes resources when an extension is shutdown. Since every time a new TextEditor is opened, we also instantiate a new ModeHandler (along other Disposables like neovim processes), those pile up and will not get properly disposed until we get shutdown one way or the other. One issue this is causing is that neovim processes are not being cleaned up and hang around until our shutdown. Thus, every time we remove a ModeHandler, we manually dispose it to free its resources. Fixes VSCodeVim#2558.
|
It sounds like you may have already found the culprit, but here's some simple repro steps I came across, in case it helps: A new nvim process is spawned each time you open a new file, even if you're reusing a tab you were using previously. |
VSC only automatically disposes resources when an extension is shutdown. Since every time a new TextEditor is opened, we also instantiate a new ModeHandler (along other Disposables like neovim processes), those pile up and will not get properly disposed until we get shutdown one way or the other. One issue this is causing is that neovim processes are not being cleaned up and hang around until our shutdown. Thus, every time we remove a ModeHandler, we manually dispose it to free its resources. Fixes #2558.
Issue Type: Performance Issue
There seem to be a lot of zombie processes. Please have a look at the process log. There are a lot of nvim processes.
Extension version: 0.11.5
VS Code version: Code - Insiders 1.23.0-insider (c1cd4378c5e5dc434ed959e13556d05240a8ca18, 2018-04-20T05:10:42.823Z)
OS version: Darwin x64 17.5.0
System Info
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Process Info
The text was updated successfully, but these errors were encountered: