-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When closing a window with :q
VS Code now selects the tab "before" the one you were previously on
#2984
Comments
My common use case from big Visual Studio vsvim extension, PHPStorm etc: This doesn't work in vscodevim, after :q for window with definition, other (maybe previously selected) tab is opened. Very annoying. Maybe is related to previously closed bug #917. |
Weirdly it does select the correct tab immediately after closing, but within a few millisecond it switches to the tab to the left. Living with this for a few months is starting to get really annoying haha. I really miss vim, it couldn't do what VS Code can but I only hit two bugs in a decade. With VS Code you discover new bugs every day. |
Deleting this line of code fixes the bug: https://github.com/VSCodeVim/Vim/blob/master/src/cmd_line/commands/quit.ts#L48 Not sure what it's supposed to be doing, but it surely can't be worth the consequences it's causing. |
Fix #2984: wrong tab selected after :quit
:q<enter>
to close the tab.I would now expect the second tab to be selected, and this worked up until recently. Now the first tab will be selected instead. It always chooses the tab "one to the left of" the tab it should be selecting.
The text was updated successfully, but these errors were encountered: