Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It seems % command is not treated like a motion #3138

Closed
alexandresw opened this issue Oct 15, 2018 · 1 comment
Closed

It seems % command is not treated like a motion #3138

alexandresw opened this issue Oct 15, 2018 · 1 comment
Labels
kind/bug

Comments

@alexandresw
Copy link

alexandresw commented Oct 15, 2018 •
edited
Loading

Describe the bug
After use command % to jump between a pair of brackets, we should be able to use command `` or <C-o> to move the cursor back to the previous bracket.

To Reproduce
Steps to reproduce the behavior:

Let suppose I have following line:
var foo = {"a", "b"}

the following sequence should replace the curl brackets for square brackets:

  1. f{ go to first bracket;
  2. % go to closing curl bracket;
  3. r] replace with closing square bracket;
  4. `` go back to open curl bracket;
  5. r[ replace with open square bracket;

Expected behavior
Step 4 should behavior as expected. (Go back to previous bracket).

Environment (please complete the following information):

  • Extension (VsCodeVim) version: 0.16.9
  • VSCode version: 1.28.0
  • OS: macOS Mojave
dsschnau added a commit to dsschnau/Vim that referenced this issue Dec 4, 2018
@dsschnau
Re-implement `` and '' with jumpTracker
3f05973 
Closes VSCodeVim#3138.

`` and '' were implemented before the new jumpTracker in PR VSCodeVim#1993.

This caused these actions to fall out-of-sync, causing issue VSCodeVim#3138 to
surface.

In addition, the jumpTracker implementation requires jumps to be on
separate lines. As far as I can tell, this behavior is not neccesary.
This commit removes that requirement, instead requiring that different
jumps be only on separate positions.
dsschnau added a commit to dsschnau/Vim that referenced this issue Dec 4, 2018
@dsschnau
Re-implement `` and '' with jumpTracker
07b4bf6 
Closes VSCodeVim#3138.

`` and '' were implemented before the new jumpTracker in PR VSCodeVim#1993.

This caused these actions to fall out-of-sync, causing issue VSCodeVim#3138 to
surface.

In addition, the jumpTracker implementation requires jumps to be on
separate lines. As far as I can tell, this behavior is not neccesary.
This commit removes that requirement, instead requiring that different
jumps be only on separate positions.
dsschnau added a commit to dsschnau/Vim that referenced this issue Dec 4, 2018
@dsschnau
Re-implement `` and '' with jumpTracker
205c8e9 
Closes VSCodeVim#3138.

`` and '' were implemented before the new jumpTracker in PR VSCodeVim#1993.

This caused these actions to fall out-of-sync, causing issue VSCodeVim#3138 to
surface.

In addition, the jumpTracker implementation requires jumps to be on
separate lines. As far as I can tell, this behavior is not neccesary.
This commit removes that requirement, instead requiring that different
jumps be only on separate positions.
dsschnau added a commit to dsschnau/Vim that referenced this issue Dec 4, 2018
@dsschnau
Re-implement `` and '' with jumpTracker
ce9dab2 
Closes VSCodeVim#3138.

`` and '' were implemented before the new jumpTracker in PR VSCodeVim#1993.

This caused these actions to fall out-of-sync, causing issue VSCodeVim#3138 to
surface.

In addition, the jumpTracker implementation requires jumps to be on
separate lines. As far as I can tell, this behavior is not neccesary.
This commit removes that requirement, instead requiring that different
jumps be only on separate positions.
@dsschnau dsschnau mentioned this issue Dec 4, 2018
Merged
dsschnau added a commit to dsschnau/Vim that referenced this issue Dec 6, 2018
@dsschnau
Re-implement and '' with jumpTrackerCloses VSCodeVim#3138. and '…
b23e952 
…' were implemented before the new jumpTracker in PR VSCodeVim#1993.This caused these actions to fall out-of-sync, causing issue VSCodeVim#3138 tosurface.In addition, the jumpTracker implementation requires jumps to be onseparate lines. As far as I can tell, this behavior is not neccesary.This commit removes that requirement, instead requiring that differentjumps be only on separate positions.
dsschnau added a commit to dsschnau/Vim that referenced this issue Dec 6, 2018
@dsschnau
Re-implement and '' with jumpTrackerCloses VSCodeVim#3138. and '…
d6e3fe9 
…' were implemented before the new jumpTracker in PR VSCodeVim#1993.This caused these actions to fall out-of-sync, causing issue VSCodeVim#3138 tosurface.In addition, the jumpTracker implementation requires jumps to be onseparate lines. As far as I can tell, this behavior is not neccesary.This commit removes that requirement, instead requiring that differentjumps be only on separate positions.
dsschnau added a commit to dsschnau/Vim that referenced this issue Dec 6, 2018
@dsschnau
Re-implement and '' with jumpTrackerCloses VSCodeVim#3138. and '…
9fbabc0 
…' were implemented before the new jumpTracker in PR VSCodeVim#1993.This caused these actions to fall out-of-sync, causing issue VSCodeVim#3138 tosurface.In addition, the jumpTracker implementation requires jumps to be onseparate lines. As far as I can tell, this behavior is not neccesary.This commit removes that requirement, instead requiring that differentjumps be only on separate positions.
dsschnau added a commit to dsschnau/Vim that referenced this issue Dec 6, 2018
@dsschnau
Re-implement and '' with jumpTrackerCloses VSCodeVim#3138. and '…
4aa980d 
…' were implemented before the new jumpTracker in PR VSCodeVim#1993.This caused these actions to fall out-of-sync, causing issue VSCodeVim#3138 tosurface.In addition, the jumpTracker implementation requires jumps to be onseparate lines. As far as I can tell, this behavior is not neccesary.This commit removes that requirement, instead requiring that differentjumps be only on separate positions.
dsschnau added a commit to dsschnau/Vim that referenced this issue Dec 6, 2018
@dsschnau
Re-implement and '' with jumpTrackerCloses VSCodeVim#3138. and '…
010036b 
…' were implemented before the new jumpTracker in PR VSCodeVim#1993.This caused these actions to fall out-of-sync, causing issue VSCodeVim#3138 tosurface.In addition, the jumpTracker implementation requires jumps to be onseparate lines. As far as I can tell, this behavior is not neccesary.This commit removes that requirement, instead requiring that differentjumps be only on separate positions.
@jpoon jpoon added the kind/bug label Dec 6, 2018
@jpoon
Copy link
Member

jpoon commented Dec 6, 2018

Closed by #3242

@jpoon jpoon closed this as completed Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpoon @alexandresw