Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled rejection when using quokka.js extension #3333

Closed
danstewart opened this issue Jan 5, 2019 · 3 comments
Closed

Unhandled rejection when using quokka.js extension #3333

danstewart opened this issue Jan 5, 2019 · 3 comments

Comments

@danstewart
Copy link

Unhandled rejection when using quokka.js extension
When using the quokka.js extensions I get a Unhandled rejection error when the new file opens and each time I type a character.

To Reproduce
Steps to reproduce the behavior:

  1. Install Quokka.js
  2. ctrl+shift+p -> Quokka.js: New JavaScript File
  3. See error
Unhandled rejection. Promise [object Promise]. Reason: AssertionError [ERR_ASSERTION]: { uri: [Getter], fileName: [Getter], isUntitled: [Getter], languageId: [Getter], version: [Getter], isClosed: [Getter] == { uri: [Getter], fileName: [Getter], isUntitled: [Getter], languageId: [Getter], version: [Getter], isClosed: [Getter].

Environment (please complete the following information):

  • Extension (VsCodeVim) version: 1.0.0
  • VSCode version: 1.30.1
  • OS: Fedoras 29

Additional context
Everything seems to work fine, it just keeps throwing the error.

@jpoon
Copy link
Member

jpoon commented Jan 5, 2019

See this for context around these error messages. #3332 (comment)

In terms of this error, we are subscribing to I handled rejections on the process. My theory is that all the extensions are run on the same process so with the extension that you installed, it's not handling this promise rejection and therefore we are displaying it as an error. I think the fix here is to remove the logging of unahndled rejections at the process level. There shouldn't be any negative side effects with this message.

@skevy
Copy link

skevy commented Jan 6, 2019

Just want to add on here that I'm also seeing this with errors from ESlint, such as those that are thrown by the plugin when it can't parse your code (such as while you're typing)

@jpoon
Copy link
Member

jpoon commented Jan 6, 2019

Yah. We should get rid of this. Obviously doesn't make sense for us to log other extensions errors. Lol. Contributions welcome if somebody wants to remove this piece of code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants