Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop logging for unresolved promise for the process. #3336

Merged
merged 1 commit into from
Jan 6, 2019

Conversation

jpoon
Copy link
Member

@jpoon jpoon commented Jan 6, 2019

What this PR does / why we need it:

  • extensions share a single process
  • stop logging for unresolved promises for the entire process as we're logging errors from other extensions

Which issue(s) this PR fixes
#3333, #3329, #3328

Special notes for your reviewer:

@jpoon jpoon merged commit 738bd95 into master Jan 6, 2019
@jpoon jpoon deleted the process_rejection branch January 6, 2019 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant