Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gT gt #338

Closed
johnfn opened this issue Jun 21, 2016 · 4 comments
Closed

gT gt #338

johnfn opened this issue Jun 21, 2016 · 4 comments

Comments

@johnfn
Copy link
Member

johnfn commented Jun 21, 2016

VSCode added tabs!!!

@johnfn johnfn added this to the v0.2 milestone Jul 5, 2016
@johnfn johnfn added the size/S label Jul 7, 2016
@sumanx
Copy link

sumanx commented Jul 14, 2016

If we can bind a VSCodeVim command with a VSCode build-in action, a lot of feature like this one will be very easy.

For example:

"vim.otherModesKeyBindings": [
       {
           "command": ["g", "t"],
           "editor": "workbench.action.nextEditor"
       }
  ]

Seems very easy but I'm new to VSCodeVim and VSCode. Maybe I should read the extension code first and try to contribute.

@johnfn
Copy link
Member Author

johnfn commented Jul 14, 2016

@sumanx A nice idea, which deserves its own issue. I lean towards no, though. The way that we add new commands (in actions.ts) is so straightforward already that there's no need to add a separate way to do so.

I bet if you take a look, you'll agree with me. 😃

@arussellk
Copy link
Contributor

I'm going to give this a shot. Please add the in-progress label.

@jpoon
Copy link
Member

jpoon commented Jul 19, 2016

@arussellk done.

arussellk added a commit to arussellk/Vim that referenced this issue Jul 20, 2016
arussellk added a commit to arussellk/Vim that referenced this issue Jul 21, 2016
Refactor gt, gT to use existing tab commands
@johnfn johnfn closed this as completed in 8762a8d Jul 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants