Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening a peek window result makes vscode-vim switch to VISUAL mode #5491

Open
ronakg opened this issue Oct 26, 2020 · 1 comment
Open

Opening a peek window result makes vscode-vim switch to VISUAL mode #5491

ronakg opened this issue Oct 26, 2020 · 1 comment

Comments

@ronakg
Copy link

ronakg commented Oct 26, 2020

Describe the bug

When a peek window is open (for example peek references), I can open a particular entry by hitting Enter. This automatically closes the peek window and jumps to the code pointed to by the peek entry. However, at this point, vscode-vim switches to VISUAL mode. It's really inconvenient because now I have to hit Escape

To Reproduce
Steps to reproduce the behavior:

Created a sample Go file for reproduction:

package main

import "fmt"

func foo() {
	fmt.Println("Hello World!")
}

func main() {
	foo()

	foo()
}

While on the definition of foo, invoke Go to References from the command palette. It should show a peek window like the following:

image

Hit enter on any of the results in the peek window to jump to the code. vscode-vim at this point switches to VISUAL mode.

Expected behavior

vscode-vim should remain in NORMAL mode.

Environment (please complete the following information):

  • Extension (VsCodeVim) version: 1.17.1
  • VSCode version: 1.50.1
  • OS: 10.15.7
@ronakg
Copy link
Author

ronakg commented Oct 28, 2020

Issue #5495 might be related to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant