1.17.[0/1] Regression: VSCode find now enters Visual mode, it should remain in Normal mode

[conoremclaughlin]

Describe the bug
VSCode's native find now enters Visual mode, it should remain in Normal mode. I've downgraded to 1.16.0 to get around it.

To Reproduce
Steps to reproduce the behavior:

1. Use VSCode's find (cmd+f for MacOSX) for any search term

Expected behavior
It should remain in normal mode. Similar to how / works for Vim's native search

Environment (please complete the following information):

• Extension (VsCodeVim) version: 1.17.1
• VSCode version: 1.50.1
• OS: Mac OSX Catalina 10.15.5

[ronakg]

Issue #5491 might be related.

[berknam]

This happens because recently a change was made so that every time vscode creates a selection Vim goes to visual mode. This is needed so you can have commands and keybindings like 'editor.action.smartSelect.grow' put you in visual mode as expected. In normal VIM the same thing happens, every time some action results in a selection VIM changes to visual mode. The same thing happens now on this extension. The problem is that there are a lot of situations that vscode creates a selection when it wasn't necessary, like when jumping in a peek window as mentioned in #5249.

The same thing happens when using vscode find, vscode selects the found word so Vim goes to visual mode. Usually when you're finding a word you intend to do something with it like copying it or replacing it and you can do that in visual mode with 'y', 'c' or even append to the word with 'A'.

Maybe this change could be behind a user setting to give the option to the user.

[Madd0g]

+1 I'm also suffering from new problems due to this (mac).

• while having a search (made with cmd+f) and having some text selected due to the searching, jumping to the end of the line (cmd+right) results in horrible cursor behavior (can't barely even explain where it's going, to some other previous line that had the text I was searching for)

[berknam]

+1 I'm also suffering from new problems due to this (mac).

* while having a search (made with cmd+f) and having some text selected due to the searching, jumping to the end of the line (cmd+right) results in horrible cursor behavior (can't barely even explain where it's going, to some other previous line that had the text I was searching for)

That is a different issue that should be fixed on the next version.

[rexkyng]

same problem here
downgraded to 1.16.0 helps

[rpavlovs]

+1 for putting it behind a flag

[sql-koala]

I wanted to try vscode Find and ran in this issue, too.

@berknam I don't know the technical detail of your PR (meaning: are the more situations where we want to capture new selection). If selection.grow is the main use case, could we not create a simple wrapper around it?
Meaning: we own the keypress, call the selection.grow command and set visualMode.

Like: export class ActionOverrideCmdD extends BaseCommand

[seriiserii825]

same problem here
downgraded to 1.16.0 helps

And how to downgrade to 1.16.0?

[rexkyng]

same problem here
downgraded to 1.16.0 helps

And how to downgrade to 1.16.0?

under "Uninstall" select "Install Another Version"

[TarasIvaschuk]

Downgrading is not a solution, because prior to 1.16. version operatorPendingModeKeyBindings not working (

[darrelhong]

PS. An easy workaround is to change the editor.findMatchBackground and editor.findMatchBorder (if desired) colours to be not fully opaque. You can do so by specifying a 8-digit hex colour where the last two characters represent the alpha channel.

[DemianParkhomenko]

Is there any solution for this issue besides the downgrade? Is this issue actual?