Repeated search of the same text doesn't work

[lqlau]

What did you do?

Want to search for words in my file.

Put the exact keys you pressed, if relevant.
Pressed "/" to filled in text to search for.
It searched for first matching word.
But when I press "/" again and hit , it should automatically continue searching the file for next match.

What did you expect to happen?

When pressing "/" and hitting it should automatically search for the last text that was searched for.

What happened instead?

Pressing "/" and hitting the second or more time does nothing. You have to manually fill in the same text each time.

Technical details:

• VSCode Version: 1.4
• VsCodeVim Version: 0.17
• OS: Windows 10 64-bit

[xconverge]

Reproduced this as well, thanks for reporting! Should be straightforward to remember what was last searched incase an empty search string is used following it.

[johnfn]

We haven't even cleared out the search history at this point. This should be like a 3 line change. 😉

[rebornix]

@johnfn seems we do https://github.com/VSCodeVim/Vim/blob/master/src/actions/actions.ts#L775 .

But it should be still simple as we only need to postpone the reinitialization.

[xconverge]

I will get to it tonight for sure if it still exists then :)

[johnfn]

@rebornix oops, just move that code to here i think https://github.com/VSCodeVim/Vim/blob/master/src/actions/actions.ts#L614

[lqlau]

Thanks @xconverge ! Which release will this fix be in?

[xconverge]

@johnfn can this be reopened or should I file a new issue? This does NOT seem to work now...

[rebornix]

@xconverge let's track it here.

[xconverge]

I 100% messed this fix up first time around...sorry, no idea what was going on there...