Motion: View not updated when moving cursor/caret to an area off screen #89
Comments
jpoon
added a commit
that referenced
this issue
Dec 3, 2015
Create a base motion class in which cursor and caret extend. The difference between the two classes: * Caret's can never have a position that at the very end of the string * Whenever we do get a styling for caret block, that logic can be placed in their respective classes. Another factor for the need to refactor was it was getting cumbersome to manipulate motions. With this refactor, motions are now composable. For instance, `new Cursor().left().up().down().move();` It will only be until the `move()` will it actually move the cursor. Fixes #89
jpoon
added a commit
that referenced
this issue
Dec 3, 2015
Create a base motion class in which cursor and caret extend. The difference between the two classes: * Caret's can never have a position that at the very end of the string * Whenever we do get a styling for caret block, that logic can be placed in their respective classes. Another factor for the need to refactor was it was getting cumbersome to manipulate motions. With this refactor, motions are now composable. For instance, `new Cursor().left().up().down().move();` It will only be until the `move()` will it actually move the cursor. Fixes #89
jpoon
added a commit
that referenced
this issue
Dec 3, 2015
Create a base motion class in which cursor and caret extend. The difference between the two classes: * Valid positioning for Caret = (0, EOL] * Valid position for Cursor = (0, EOL) * Whenever we do get a styling for cursor/caret, that logic can be placed in their respective classes. Motions were becoming cumbersome. With this refactor, motions are now composable making repeatable actions super easy: `new Cursor().left().left().left().up().down().move(); The UI updates on the `move()` command. Also fixes #89 in this refactor.
jpoon
added a commit
that referenced
this issue
Dec 3, 2015
Create a base motion class in which cursor and caret extend. The difference between the two classes: * Valid positioning for Caret = (0, EOL] * Valid position for Cursor = (0, EOL) * Whenever we do get a styling for cursor/caret, that logic can be placed in their respective classes. Motions were becoming cumbersome. With this refactor, motions are now composable making repeatable actions super easy: `new Cursor().left().left().left().up().down().move(); The UI updates on the `move()` command. Also fixes #89 in this refactor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: