Fixes #1594: <Copy> drops the first and last line when selecting in visual line mode from the bottom up #1604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, very nicely done. You even used my EarlierOf and LaterOf idioms. I'm so happy! |
|
Haha are they not commonly used by other people? It was either that or have two if statements, and I was like "oh! This is exactly what I was looking for." Maybe we should have a function that takes in two positions and returns a tuple of them in sorted order? |
|
Haha - the number of times I/other contributors have reinvented various wheels in this repository is probably embarrassingly high for all of us. 😁 Your tuple solution sounds great too. Honestly, it probably even exists somewhere. 😉 |
Chillee
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another pretty simple bug fix.
start is not necessarily before stop in visual mode (start is where the cursor is currently, and stop is the "stop" of your selection).