VsCodeNeovim #1897
Closed
VsCodeNeovim #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyvg
reviewed
Jul 4, 2017
neovim.ts
Outdated
| return [row - 1, character - 1]; | ||
| } | ||
|
|
||
| static async getCursorPos(): Promise<[number, number]> { |
There was a problem hiding this comment.
Vim.nv.cursor will return the cursor position (there is no equivalent to getpos though
…ixed <C-v> in insert mode)
…into VSCodeNeovim
…ma/multiple-cursors
…handleTextDocumentChange
…ts have been setn)
|
Going to close this PR as development of the neovim rewrite is over at: https://github.com/Chillee/VSCodeNeovim and therefore all discussion of neovim rewrite should move over there. @Chillee do you want to move it under the VSCodeVim org? makes it more easily discoverable. You should have the rights to do that if you choose. |
|
@Chillee sounds awesome. Will any further updates about any future merge into VSCodeVim be posted to this issue? I'll subscribe! |
|
@karlhorky No work been done on it since a month before your comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The neovim rewrite!
For design doc/decisions/limitations/a rough idea of what's done, check here:
https://slack-files.com/T0ENVGY1E-F62R31A5V-1be4436e6c
Pretty much everything is in
neovim.tsandextension.tsIf anybody has suggestions on anything about the design doc, or they have questions about any design choices, I'd be happy to listen to them.
(While I'm working on this I'll likely be less responsive to issues. Many of the current bugs would be fixed by this pr so please understand that I have less motivation to fix them).