-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to paragraph text objects. #1996
Conversation
It's not clear to me that the test is actually a failure and not just a result of you fixing the bug. Feel free to replace that test with a |
Nope, I definitely broke sentences, which treat whitespace-only lines differently. Will fix it and add some tests. |
For my own reference as I fix this, this is in the vim help:
And:
|
Normal sentence and paragraph motions differ in behavior from text-objects. The (){} commands treat whitespace as part of paragraphs, but ap and ip should treat whitespace lines as if they were completely empty.
Also handle ip for "blank paragraphs" correctly. Fixes VSCodeVim#1994
d2ec4d3
to
a35a3fe
Compare
OK, I've fixed sentence handling and made even more fixes to "inner" paragraph handling. This time, I used "find all references" to ensure I didn't affect any other code paths. |
Looks good to me! |
See individual commit messages and associated issues for details.