Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readds vimState.lastClickWasPastEOL. Fixes #2404 #2433

Merged
merged 2 commits into from
Mar 9, 2018
Merged

Readds vimState.lastClickWasPastEOL. Fixes #2404 #2433

merged 2 commits into from
Mar 9, 2018

Conversation

Chillee
Copy link
Member

@Chillee Chillee commented Mar 8, 2018 •
edited
Loading

We need it to be part of vimstate because we need state that persists between multiple calls to handleSelectionChange.

@jpoon
Copy link
Member

jpoon commented Mar 8, 2018 •
edited
Loading

Argh, sorry about this. @Chillee thanks for fixing.

@jpoon jpoon self-requested a review March 9, 2018 05:56
@Chillee Chillee merged commit 819fc1d into VSCodeVim:master Mar 9, 2018
@xconverge
Copy link
Member

This code still makes me shudder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpoon jpoon jpoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Chillee @jpoon @xconverge