Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixs #2325 Cmd+D loses multiple selections #2684

Closed

Conversation

redhat008
Copy link

@redhat008 redhat008 commented May 25, 2018

What this PR does / why we need it:

Fix the bug. Cmd+D loses multiple selections #2325

Which issue(s) this PR fixes

fixs #2325 Cmd+D loses multiple selections

Special notes for your reviewer:

  1. only test in my computer
  2. I am a programmer, but not familiar with typescript/js and vscode extension development. Just compare with 0.10 with 0.12 code . the logic have changed , so produce issue Improve Test Infrastructure #2335

@TravisBuddy
Copy link

Hey @redhat008,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because something unrelated to the tests, like a problem a dependency or the build process itself.

@xconverge
Copy link
Member

I had recently added https://github.com/VSCodeVim/Vim/blob/master/test/multicursor.test.ts

Is there any chance you can add a test without your fix, and then make sure it passes with your fix?

These are tricky issues and I would love to catch them in tests if possible! Thanks

@redhat008
Copy link
Author

Sorry. I'm not familiar with typescript/js and vscode extension development. I don't know how to add the test

@jpoon
Copy link
Member

jpoon commented Jun 2, 2018

You can take a look at our existing tests. For instance:

test('Can handle x across a selection', async () => {
f

@xconverge
Copy link
Member

The file I linked has 2 other tests, you can just mimic one of them and add it to that file even multicursor.test.ts

@redhat008 redhat008 closed this Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants