feat: Update <C-u> insert mode behavior #2805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of deleting whole line, it deletes from cursor position, and takes leading indentation into account. Relates to VSCodeVim#2804
|
thanks for doing the trifecta: filing an issue, submitting a PR, AND writing tests 👏. Left a comment, but pretty much LGTM. |
jpoon
reviewed
Jul 4, 2018
test/mode/modeInsert.test.ts
Outdated
| @@ -172,6 +172,45 @@ suite('Mode Insert', () => { | |||
| end: ['foo|bar'], | |||
| }); | |||
|
|
|||
| test("Can handle '<C-u>'", async () => { | |||
There was a problem hiding this comment.
Is there a reason you decided to write the test in this style vs the newTest? IMO, should be OK to have this in the style of the newTest like the ones you have below.
There was a problem hiding this comment.
I just mimiced the tests above for <C-w>, I'll change it to the newTest style. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
"Fixes" the behavior of <C-u> in Insert mode.
Which issue(s) this PR fixes
Fixes #2804
Special notes for your reviewer:
See issue for reasoning, and let me know if I've missed anything or if you disagree. 🙂