Remappings not applying with operators that enter insert mode

[shawnaxsom]

What this PR does / why we need it:

#3081 handled allowing remapping black hole operator deletion, but this lead to a regression. It bypassed remapping for any operator in action, but it should still remap for any operator in action in normal mode.

For example,ciwjj with jj -> <Esc> mapping should result in cutting inner word, then exiting back to normal mode, but it does not. The remapping doesn't apply since the code is checking for an operator in recordedState; the whole ciwjj combination is a full recorded state, and therefore the "c" operator exists the whole time.

We should therefore be preventing "d" in "dd" normal mode from being remapped, as Vim seems to do, to allow black hole deletion remappings still. But we shouldn't prevent remappings if the operator puts us into e.g. Insert Mode.

Which issue(s) this PR fixes

fixes #3088

Special notes for your reviewer:

I refactored the remapper unit tests slightly. I added a test that only remapped what it was actually testing. This ensures other unconcerned remappings won't interefere, and it is also more explicit and understandable IMO. I preserved the setup logic for existing tests to use all remappings as before, though maybe we should be more explicit with those tests as well.

[TravisBuddy]

Hey @shawnaxsom,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 4741ee20-c842-11e8-95f5-19ba20551b8b