Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3149: broken table of contents links #3151

Merged
merged 1 commit into from
Oct 20, 2018

Conversation

westim
Copy link
Contributor

@westim westim commented Oct 20, 2018

What this PR does / why we need it:

Fixes broken section links to Settings and Multi-Cursor Mode in the README table of contents.

Which issue(s) this PR fixes

#3149

Special notes for your reviewer:

The issue is caused by the emoji which use Variation Selector-16. When inspecting the HTML, the anchor appears as href="# -settings". The following hyperlink variations did not work correctly:

  • [Settings](# -settings) (Not recognized as a link)
  • [Settings](#--settings)
  • <a href="# -settings"</a>

See gist for variations that work by inserting the Variation Selector-16 character.

@jpoon jpoon merged commit b972aec into VSCodeVim:master Oct 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants