Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update roadmap for split and new #3184

Merged
merged 2 commits into from
Nov 1, 2018
Merged

docs: update roadmap for split and new #3184

merged 2 commits into from
Nov 1, 2018

Conversation

jpoon
Copy link
Member

@jpoon jpoon commented Nov 1, 2018

What this PR does / why we need it:

doc updates to roadmap for :split and :new
Which issue(s) this PR fixes

Special notes for your reviewer:

@TravisBuddy
Copy link

Travis tests have failed

Hey @jpoon,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Node.js: 8

View build log

if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; fi
diff --git a/ROADMAP.md b/ROADMAP.md
index 4eaa19b..361faed 100644
--- a/ROADMAP.md
+++ b/ROADMAP.md
@@ -524,9 +524,9 @@ Since the list is too long, now we just put those already supported options here
 | ------------------------- | ----------------- | ----------------------------------------------------------------------- | ---------------------------------------------------------------------------------------------------------------------- |
 | :white_check_mark: :star: | :e[dit] {file}    | Edit {file}.                                                            | We will open file in a new Tab of current Grouped Editor instead of opening in current tab.                            |
 | :white_check_mark: :star: | <ctrl-w> hl | Switching between windows.                                              | As we don't have the concept of Window in VS Code, we are mapping these commands to switching between Grouped Editors. |
-| :white_check_mark:         | :sp {file}        | Split current window in two.                                            | VS Code doesn't support split Window horizontally.                                                                     |
+| :white_check_mark:        | :sp {file}        | Split current window in two.                                            | VS Code doesn't support split Window horizontally.                                                                     |
 | :white_check_mark: :star: | :vsp {file}       | Split vertically current window in two.                                 | VS Code only supports three vertical window at most and that's the limitation of this command.                         |
-| :white_check_mark:         | :new              | Create a new window horizontally and start editing an empty file in it. | VS Code doesn't support split Window horizontally.                                                                     |
+| :white_check_mark:        | :new              | Create a new window horizontally and start editing an empty file in it. | VS Code doesn't support split Window horizontally.                                                                     |
 | :white_check_mark: :star: | :vne[w]           | Create a new window vertically and start editing an empty file in it.   | VS Code only supports three vertical window at most and that's the limitation of this command.                         |
 
 ## Tabs
diff --git a/src/configuration/configuration.ts b/src/configuration/configuration.ts
index 9ebc52e..5cc82bf 100644
--- a/src/configuration/configuration.ts
+++ b/src/configuration/configuration.ts
@@ -287,24 +287,14 @@ class Configuration implements IConfiguration {
   @overlapSetting({
     settingName: 'lineNumbers',
     defaultValue: true,
-    map: new Map([
-      ['on', true],
-      ['off', false],
-      ['relative', false],
-      ['interval', false],
-    ]),
+    map: new Map([['on', true], ['off', false], ['relative', false], ['interval', false]]),
   })
   number: boolean;
 
   @overlapSetting({
     settingName: 'lineNumbers',
     defaultValue: false,
-    map: new Map([
-      ['on', false],
-      ['off', false],
-      ['relative', true],
-      ['interval', false],
-    ]),
+    map: new Map([['on', false], ['off', false], ['relative', true], ['interval', false]]),
   })
   relativenumber: boolean;
 
@@ -374,9 +364,9 @@ function overlapSetting(args: {
   defaultValue: OptionValue;
   map?: Map<string | number | boolean, string | number | boolean>;
 }) {
-  return function (target: any, propertyKey: string) {
+  return function(target: any, propertyKey: string) {
     Object.defineProperty(target, propertyKey, {
-      get: function () {
+      get: function() {
         if (this['_' + propertyKey] !== undefined) {
           return this['_' + propertyKey];
         }
@@ -388,7 +378,7 @@ function overlapSetting(args: {
 
         return val;
       },
-      set: function (value) {
+      set: function(value) {
         this['_' + propertyKey] = value;
 
         if (value === undefined || Globals.isTesting) {
diff --git a/src/configuration/remapper.ts b/src/configuration/remapper.ts
index 658a884..3f71a7f 100644
--- a/src/configuration/remapper.ts
+++ b/src/configuration/remapper.ts
@@ -107,7 +107,9 @@ export class Remapper implements IRemapper {
         await vimState.historyTracker.undoAndRemoveChanges(
           Math.max(0, numCharsToRemove * vimState.allCursors.length)
         );
-        vimState.allCursors = vimState.allCursors.map(x => x.withNewStop(x.stop.getLeft(numCharsToRemove)));
+        vimState.allCursors = vimState.allCursors.map(x =>
+          x.withNewStop(x.stop.getLeft(numCharsToRemove))
+        );
       }
 
       // We need to remove the keys that were remapped into different keys
diff --git a/src/util/historyFile.ts b/src/util/historyFile.ts
index 7ce4608..ca254d2 100644
--- a/src/util/historyFile.ts
+++ b/src/util/historyFile.ts
@@ -66,9 +66,7 @@ export class HistoryFile {
           mkdirp.sync(this._historyDir, 0o775);
         }
       } catch (err) {
-        logger.error(
-          `Failed to create directory. path=${this._historyDir}. err=${err}.`
-        );
+        logger.error(`Failed to create directory. path=${this._historyDir}. err=${err}.`);
         reject(err);
       }
 
Prettier Failed. Run [05:07:18] Using gulpfile ~/build/VSCo
TravisBuddy Request Identifier: 09fd1780-dd94-11e8-9e24-43be9eb2178e

@jpoon jpoon merged commit 8e0a99d into master Nov 1, 2018
@jpoon jpoon deleted the roadmap branch November 1, 2018 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants