Fix C-n and C-p in autocomplete for multi cursor
#3283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes jumping the autocomplete options in multi cursors so that it only jumps one at a time. Without this fix it jumps once _per cursor_, so if I have 3 cursors, I am forced to traverse the list 3 at a time. I initially found this as part of VSCodeVim#3282.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This fixes jumping the autocomplete options in multi cursors so that it
only jumps one at a time. Without this fix it jumps once per cursor,
so if I have 3 cursors, I am forced to traverse the list 3 at a time.
I initially found this as part of #3282.
This doesn't solve my original issue (that autocomplete doesn't appear), but does solve the traversing bug.
Which issue(s) this PR fixes
Part of #3282.
Special notes for your reviewer:
Happy to take feedback and update the PR - not sure if you'd want a test covering this fix or not but I may need some guidance on doing that :)