fix: slightly improve perf by caching vscode context #3293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xconverge
reviewed
Dec 27, 2018
|
This is a REALLY good idea, nice job |
jpoon
force-pushed
the
cache_vscode_context
branch
from
addf012 to
08fa2cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The following operation
vscode.commands.executeCommand('setContext', ...takes roughly 1s to complete. Cache the value and only update vscode context when value changes.We had done this for some of the context values. This PR does it for all context values.
Which issue(s) this PR fixes
Probably doesn't wholly address #1714, but it's a step in that direction.
Special notes for your reviewer: