Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: log warning if remapped command does not exist. closes #3307 #3314

Merged
merged 1 commit into from
Jan 1, 2019
Merged

fix: log warning if remapped command does not exist. closes #3307 #3314

merged 1 commit into from
Jan 1, 2019

Conversation

jpoon
Copy link
Member

@jpoon jpoon commented Jan 1, 2019 •
edited
Loading

What this PR does / why we need it:

  • As there are cases where the command has not yet been registered by VS Code (ie. when an extension has not yet been activated), we can't ignore these remapped commands, so instead we'll log a warning
  • Properly fixes Keybindings reset on invalid command #3295, but not awaiting the executeCommand and allowing the task queue to catch the error.

Which issue(s) this PR fixes
#3295, #3307

Special notes for your reviewer:
@xconverge this is likely going to conflict with your async PR

@jpoon jpoon force-pushed the fix3307 branch 2 times, most recently from ae14bc3 to 416690b Compare January 1, 2019 09:24
@VSCodeVim VSCodeVim deleted a comment from TravisBuddy Jan 1, 2019
@jpoon jpoon merged commit 3dd6b48 into master Jan 1, 2019
@jpoon jpoon deleted the fix3307 branch January 1, 2019 21:16
@jpoon jpoon mentioned this pull request Jan 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keybindings reset on invalid command
1 participant
@jpoon