-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: defer to mkdirp for checking if directory exists #3337
Conversation
Travis tests have failedHey @jpoon, Node.js: 8if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; fi
npm test --silent
TravisBuddy Request Identifier: 641f36b0-1194-11e9-a449-0b9a49f18a3c |
63be258
to
e3428bb
Compare
Travis tests have failedHey @jpoon, Node.js: 8if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; fi
npm test --silent
TravisBuddy Request Identifier: cc4783c0-119c-11e9-a449-0b9a49f18a3c |
Travis tests have failedHey @jpoon, Node.js: 8if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; fi
npm test --silent
TravisBuddy Request Identifier: 87b19290-119d-11e9-a449-0b9a49f18a3c |
What this PR does / why we need it:
I think this should resolve #3330. I say think because I wasn't able to repro the initial error on my machine. This PR replaces how we check for a directory existing from using
fs.exists
which has been deprecated to deferring tomkdirp
which handles when a directory already exists.Which issue(s) this PR fixes
#3330
Special notes for your reviewer: