Run closeMarkersNavigation on ESC. Fix #3367
#3416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM thanks |
|
@xconverge Can we make this a setting? A list of commands to run when pressing ESC. Try Option + F3 — ESC do not close the inline diff view either. Through microsoft/vscode#36566 (comment) I get that
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
After running F8 to jump to next diagnostic location, ESC cannot dismiss the inline problems view (unless you click to focus into it).
See microsoft/vscode#66684 (comment) for the command added.
Which issue(s) this PR fixes
Special notes for your reviewer:
Same addition as #1707.