Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check neovim configurations and timeout on nvim attach #3437

Merged
merged 1 commit into from
Feb 1, 2019
Merged

Conversation

jpoon
Copy link
Member

@jpoon jpoon commented Feb 1, 2019

What this PR does / why we need it:
Check neovim configurations for validity and disables neovim if anything is amiss. Timeout when trying to attach neovim process.

Which issue(s) this PR fixes
#3433

Special notes for your reviewer:

@jpoon jpoon changed the title fix: check neovim configurations and timeout on nvim attach. mitigate… fix: check neovim configurations and timeout on nvim attach Feb 1, 2019
@jpoon jpoon merged commit 1ac7a2c into master Feb 1, 2019
@jpoon jpoon deleted the nvim branch February 1, 2019 01:16
@xconverge
Copy link
Member

This broke my setup where I just had 'nvim' as the path

This then lets me use the same config (synced with settings sync) and environment variables with both Linux and Windows

@jpoon
Copy link
Member Author

jpoon commented Feb 1, 2019

Does that mean you have nvim running in the same working directory as vscodevim?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants