Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CamelCaseMotion plugin #3483
Add CamelCaseMotion plugin #3483
Changes from 5 commits
a4cd568
f55c6f6
2eb7e67
62d4a68
35d0e58
9e991a9
52002c1
f30eb37
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to make this more hierarchic. Can you make this
vim.camelCaseMotion.enable
instead? Such that if we do end up creating more configs for camel case, they can live undervim.camelCaseMotion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea! I've switched the setting over as you suggested and pushed the new changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we should move away from having
position.ts
the dumping ground for all positioning related logic as it's a bit of a mess.As the changes you introduced to this file are specific to camel case, I wonder if we should create a new file under /plugins
camelcase.position.ts
?What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not opposed to the idea in principle, but if I were to move I'd either have to duplicate or make public all the
get*Word*WithRegex
functions and maybe thegetAllPositions
family of functions since they're shared among all the word-based motions. Your call, I'm happy either way!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ermagod. Thank you for writing comments.