-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only use regex lookbehind where supported #3525
Conversation
This is very similar to what I was testing. Looks fine. Special note that if a user is building vscodevim on an older branch that some test cases will fail, but seems fine to just say that is disallowed. |
Closing this since nobody has complained that they can't upgrade VSCode yet. Will keep the branch around for now though in case it becomes necessary |
Hey! We're using VSCodeVIM inside CodeSandbox (https://codesandbox.io/s/new), which runs VSCode + extensions. For our VIM Mode we use VSCodeVIM (thanks for building this!). This worked great so far, but we found out that lookbehind regexpressions are not supported in Firefox. I can imagine that this is a very unusual request but would you be open to a PR that adds the lookbehind check and disables it if it detects Firefox/Safari? |
reopening for consideration since it seems like there are some legit use cases |
is this working? I'm trying to access code-server via firefox reality and it gives me this error. would be really cool if I could code in VR and so far this is the only roadblock :( anyways thanks for building VSCodeVim, it's really fine! |
This was removed again in 1d273eb#diff-4eb584e50b8970dfd9f200f6d934f418 |
I'm using vscode 1.46.1 through code-server on ipad and I'm getting:
|
Ah, I hadn't considered us running in the browser when I removed that. I'll fix it momentarily. |
Thanks so much guys! |
Seems is still not working, I tested from master and still has errors with some grouped regex. |
@J-Fields any luck? |
What this PR does / why we need it:
Users on older versions of VSCode were hitting bugs because of lookbehinds in the camel case motion regex. This should fix the issue for those users.
Which issue(s) this PR fixes
Fixes #3522
Special notes for your reviewer:
I didn't get to test this myself on an older version of VSCode. But I think it should work?