Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links in README.md #3842

Merged
merged 1 commit into from
Jun 22, 2019
Merged

Fix broken links in README.md #3842

merged 1 commit into from
Jun 22, 2019

Conversation

aquova
Copy link
Contributor

@aquova aquova commented Jun 19, 2019

Fixes broken links regarding logging level settings. As far as
I can tell, these links have never been valid, and should direct
to the information regarding VSCodeVim's settings.

What this PR does / why we need it:
There are two links in the read me that currently don't redirect anywhere due to non-existent headers. This fixes those links.

Which issue(s) this PR fixes
#3827

Special notes for your reviewer:

Fixes broken links regarding logging level settings. As far as
I can tell, these links have never been valid, and should direct
to the information regarding VSCodeVim's settings.
@TravisBuddy
Copy link

Travis tests have failed

Hey @aquova,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Node.js: 8

View build log

if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; fi
The command "if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; fi" exited with 0.

$ npm run build

> [email protected] build /home/travis/build/VSCodeVim/Vim
> gulp build

[04:20:43] Using gulpfile ~/build/VSCodeVim/Vim/gulpfile.js
[04:20:43] Starting 'build'...
[04:20:43] Starting 'prettier'...
[04:20:45] Finished 'prettier' after 2.24 s
[04:20:45] Starting 'tsc'...
[04:20:45] Starting 'tslint'...
[04:20:53] Finished 'tslint' after 7.73 s
[04:21:02] Finished 'tsc' after 17 s
[04:21:02] Starting 'commit-hash'...
[04:21:02] Finished 'commit-hash' after 28 ms
[04:21:02] Finished 'build' after 19 s
The command "npm run build" exited with 0.

$ npm test --silent
### VS Code Extension Test Run ###

Current working directory: /home/travis/build/VSCodeVim/Vim
Downloaded VS Code 1.35.1
Running extension tests: /home/travis/build/VSCodeVim/Vim/.vscode-test/vscode-1.35.1/VSCode-linux-x64/code /home/travis/build/VSCodeVim/Vim/out/test --extensionDevelopmentPath=/home/travis/build/VSCodeVim/Vim --extensionTestsPath=/home/travis/build/VSCodeVim/Vim/out/test --locale=en
Tests exited with code: 1
The command "npm test --silent" exited with 1.



Done. Your build exited with 1.
npm test --silent
### VS Code Extension Test Run ###

Current working directory: /home/travis/build/VSCodeVim/Vim
Downloaded VS Code 1.35.1
Running extension tests: /home/travis/build/VSCodeVim/Vim/.vscode-test/vscode-1.35.1/VSCode-linux-x64/code /home/travis/build/VSCodeVim/Vim/out/test --extensionDevelopmentPath=/home/travis/build/VSCodeVim/Vim --extensionTestsPath=/home/travis/build/VSCodeVim/Vim/out/test --locale=en
Tests exited with code: 1
TravisBuddy Request Identifier: a9513450-9249-11e9-b30b-d1962db218c4

@jpoon jpoon merged commit d76f13a into VSCodeVim:master Jun 22, 2019
@J-Fields J-Fields mentioned this pull request Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants