Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build per microsoft/vscode#75873 #3857

Merged
merged 3 commits into from
Jun 27, 2019
Merged

Fix build per microsoft/vscode#75873 #3857

merged 3 commits into from
Jun 27, 2019

Conversation

octref
Copy link
Contributor

@octref octref commented Jun 27, 2019

Fix Linux build on Travis. See microsoft/vscode#75873.

@jpoon
Copy link
Member

jpoon commented Jun 27, 2019

Oh snap, didn't see this PR. Made the same change. Thanks @octref

@octref
Copy link
Contributor Author

octref commented Jun 27, 2019

@jpoon Your change won't work as multi-line scripts need to have |:

before_install:
- |
  if...
    ...
  fi

@octref
Copy link
Contributor Author

octref commented Jun 27, 2019

And I have tested, /usr/bin/Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 & with semicolon in the end would cause a syntax error. Maybe you can use (/usr/bin/Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &);.

Before this commit my build failed as well: octref/vscode-test-sample@0787a54

@jpoon
Copy link
Member

jpoon commented Jun 27, 2019

Reverted my commit and will just take yours as soon as this builds.

@jpoon jpoon merged commit 3bee1a5 into VSCodeVim:master Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants